Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edmCheckMultithreading: check for non multithreading-compliant modules #11242

Merged
merged 1 commit into from
Sep 16, 2015
Merged

edmCheckMultithreading: check for non multithreading-compliant modules #11242

merged 1 commit into from
Sep 16, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 14, 2015

Check if the modules used by the CONFIG python file are legacy,
global, stream or one modules, and if they implement the
fillDescriptions() method.

@fwyzard
edmCheckMultithreading: check for non multithreading-compliant modules
9ae3e16 
Check if the modules used by the CONFIG python file are `legacy`,
`global`, `stream` or `one` modules, and if they implement the
`fillDescriptions()` method.
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Sep 14, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_5_X.

edmCheckMultithreading: check for non multithreading-compliant modules

It involves the following packages:

FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 14, 2015

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 14, 2015

though it just adds a new script, so it's very unlikely to break anything...

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 9ae3e16
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11242/8042/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11242/8042/summary.html

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 16, 2015
@cmsbuild
Merge pull request #11242 from fwyzard/edmCheckMultithreading_75x
696d886 
edmCheckMultithreading: check for non multithreading-compliant modules
@cmsbuild cmsbuild merged commit 696d886 into cms-sw:CMSSW_7_5_X Sep 16, 2015
@fwyzard fwyzard deleted the edmCheckMultithreading_75x branch September 23, 2015 20:05
@fwyzard fwyzard restored the edmCheckMultithreading_75x branch September 23, 2015 20:05
@fwyzard fwyzard deleted the edmCheckMultithreading_75x branch September 23, 2015 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @Dr15Jones @davidlange6