Misc. streams related fixes #11325
Misc. streams related fixes #11325
Conversation
GCC 5.2.0 does not allow piping output stream into output stream, e.g., `std::cout` << `std::cout`. There is no more impilicit conversion to `void *` since C++11. `std::cout` does not directly support `std::basic_stringstream` as argument, but because `std::basic_stringstream` inherits `std::basic_ios` and it supports operator `void*` (until C++11) one could have pushed it to `std::cout`. That is wrong, because `operator void*() const` does not provide string content of `std::basic_stringstream`. Instead use `str()` method to get a string copy of `std::basic_stringstream` content. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_6_X. Misc. streams related fixes It involves the following packages: CondFormats/SiStripObjects @civanch, @Dr15Jones, @cvuosalo, @emeschi, @ianna, @mdhildreth, @monttj, @cmsbuild, @ggovi, @diguida, @cerminar, @deguio, @slava77, @mommsen, @vadler, @mmusich, @mulhearn, @danduggan can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
Misc. streams related fixes
GCC 5.2.0 does not allow piping output stream into output stream, e.g.,
std::cout << std::cout. There is no more impilicit conversion tovoid *since C++11.
std::coutdoes not directly supportstd::basic_stringstreamasargument, but because
std::basic_stringstreaminheritsstd::basic_iosand it supports operator
void*(until C++11) one could have pushed itto
std::cout. That is wrong, becauseoperator void*() constdoes notprovide string content of
std::basic_stringstream. Instead usestr()method to get a string copy of
std::basic_stringstreamcontent.Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch