Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version numbers consistent with 7_4_X #11365

Merged
merged 1 commit into from
Sep 20, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Sep 18, 2015

The ROOT class version numbers for class pat::PackedCandidate have recently become inconsistent between 7_4_X and 7_5_X, in that version 23 is used for different checksums in the two releases.
Fortunately, the version actually used in 7_5_X (version 21) is consistent, so no harm has yet been done. Nonetheless, to prevent possible severe problems in the future, this PR makes the class versions in 7_5_X consistent with 7_4_X.
Since this is purely technical, it should be expedited.

@wmtan
Copy link
Contributor Author

wmtan commented Sep 18, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Sep 18, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Make version numbers consistent with 7_4_X

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Sep 20, 2015
Make version numbers consistent with 7_4_X
@davidlange6 davidlange6 merged commit c1fdea7 into cms-sw:CMSSW_7_5_X Sep 20, 2015
@wmtan wmtan deleted the MakeVersionNumbersConsistent branch September 20, 2015 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants