Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented Bessel's correction to remove bias in Time Uncrt estimati… #11460

Merged

Conversation

pietverwilligen
Copy link
Contributor

…on of ME0Segment

@pietverwilligen
Copy link
Contributor Author

please test :-)

@slava77
Copy link
Contributor

slava77 commented Sep 24, 2015

@cmsbuild please test

the change looks simple

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 24, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pietverwilligen (Piet Verwilligen) for CMSSW_7_6_X.

implemented Bessel's correction to remove bias in Time Uncrt estimati

It involves the following packages:

RecoLocalMuon/GEMSegment

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11460 738ca21

Minor adjustment to ME0 segment time estimate to remove bias. There should be no change in monitored quantities.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-24-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 26, 2015
…ncrtBias

implemented Bessel's correction to remove bias in Time Uncrt estimati…
@cmsbuild cmsbuild merged commit 81ac01a into cms-sw:CMSSW_7_6_X Sep 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants