Fix Tracking Seed and Candidate Plots, add DCA and SIP to global Muons #11467

VinInn · 2015-09-24T17:23:33Z

Fix Seed and Candidate eta-phi plots: now using position not direction
Add vertex track-multiplicity vs z plot
Add DCA and SIP plots for globalMuons

cmsbuild · 2015-09-24T17:26:22Z

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_6_X.

Fix Tracking Seed and Candidate Plots, add DCA and SIP to global Muons

It involves the following packages:

DQM/TrackingMonitor
DQMOffline/RecoB
RecoTracker/IterativeTracking

@cvuosalo, @slava77, @cmsbuild, @deguio, @danduggan, @vanbesien can you please review it and eventually sign? Thanks.
@ghellwig, @imarches, @makortel, @threus, @acaudron, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @mschrode, @istaslis, @ferencek, @cerati, @pvmulder, @dgulhan, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

deguio · 2015-09-24T18:08:13Z

please test

cmsbuild · 2015-09-24T18:16:12Z

The tests are being triggered in jenkins.

slava77 · 2015-09-24T18:27:41Z

DQM/TrackingMonitor/src/TrackBuildingAnalyzer.cc

-  double eta          = state.globalMomentum().eta();
-  double phi          = state.globalMomentum().phi();
-  double theta        = state.globalMomentum().theta();
+  double eta          = state.globalPosition().eta();


while it's not in reco code, this looks odd to me.
I just wanted to check that these should be the detector surface eta/phi/theta values.
... same question for inner/outer position eta,phi (the innermost state position eta, say, for r_hit~4cm will be anywhere from ~-3 to +3 depending where the z_POCA is).

POCA is the main issue. we whant to correlate with detector issues, not to physics...
so indeed eta computed from direction was pretty random, smearing any real feature in particular at large r.
now detector issue shows up immediately. will show examples tomorrow at trk dpg meeting

remove a mod that was not supposed to be committed...

cmsbuild · 2015-09-24T19:16:36Z

Pull request #11467 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

cmsbuild · 2015-09-24T21:04:53Z

-1
Tested at: 18ca7f7
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 24-Sep-2015 21:46:27 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 182124 lumi: 40 event: 1898098
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module TrackingMonitor/'MonitorTrackGLBMuons'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: offlinePrimaryVertices
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11467/8361/summary.html

VinInn · 2015-09-25T13:00:53Z

will eventually fix HI

VinInn · 2015-09-27T12:51:15Z

140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI Step0-PASSED Step1-PASSED Step2-PASSED - time date Sun Sep 27 14:49:04 2015-date Sun Sep 27 14:43:27 2015; exit: 0 0 0
1 1 1 tests passed, 0 0 0 failed

cmsbuild · 2015-09-27T12:56:11Z

Pull request #11467 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

deguio · 2015-09-28T09:45:17Z

please test

cmsbuild · 2015-09-28T09:46:13Z

The tests are being triggered in jenkins.

cmsbuild · 2015-09-28T11:38:58Z

+1
Tested at: 08b3daf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11467/8422/summary.html

cmsbuild · 2015-09-28T12:32:39Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11467/8422/summary.html

deguio · 2015-09-28T13:49:34Z

+1

cmsbuild · 2015-09-28T13:52:25Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-09-29T05:41:33Z

+1

Fix Tracking Seed and Candidate Plots, add DCA and SIP to global Muons

VinInn added 4 commits September 22, 2015 18:59

new histos etaphi and validfraction, move to position etaphi for seeds

5236a9b

fix candidate eta/phi

c3d4334

add track etaphi inner/outer

8b569c2

new histo NtinV vs z, enable dca and sip for globalMuon

18ca7f7

cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 24, 2015

cmsbuild added reconstruction-pending dqm-pending pending-signatures tests-pending orp-pending comparison-pending labels Sep 24, 2015

cmsbuild added tests-started and removed tests-pending labels Sep 24, 2015

slava77 reviewed Sep 24, 2015
View reviewed changes

Update TobTecStep_cff.py

980906f

remove a mod that was not supposed to be committed...

cmsbuild added tests-pending and removed reconstruction-pending tests-started labels Sep 24, 2015

Merged TkDQM2 from repository VinInn

df49af4

cmsbuild added tests-rejected and removed tests-pending labels Sep 24, 2015

protect against missing collection (as in HI for muons)

08b3daf

cmsbuild added tests-pending and removed tests-rejected labels Sep 27, 2015

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2015

cmsbuild added tests-approved and removed tests-started labels Sep 28, 2015

cmsbuild added comparison-available and removed comparison-pending labels Sep 28, 2015

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Sep 28, 2015

cmsbuild added orp-approved and removed orp-pending labels Sep 29, 2015

cmsbuild added a commit that referenced this pull request Sep 29, 2015

Merge pull request #11467 from VinInn/TkDQM2

8f7ce9a

Fix Tracking Seed and Candidate Plots, add DCA and SIP to global Muons

cmsbuild merged commit 8f7ce9a into cms-sw:CMSSW_7_6_X Sep 29, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Tracking Seed and Candidate Plots, add DCA and SIP to global Muons #11467

Fix Tracking Seed and Candidate Plots, add DCA and SIP to global Muons #11467

VinInn commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

deguio commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

slava77 Sep 24, 2015

VinInn Sep 24, 2015

cmsbuild commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

VinInn commented Sep 25, 2015

VinInn commented Sep 27, 2015

cmsbuild commented Sep 27, 2015

deguio commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

deguio commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

davidlange6 commented Sep 29, 2015

Fix Tracking Seed and Candidate Plots, add DCA and SIP to global Muons #11467

Fix Tracking Seed and Candidate Plots, add DCA and SIP to global Muons #11467

Conversation

VinInn commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

deguio commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

slava77 Sep 24, 2015

Choose a reason for hiding this comment

VinInn Sep 24, 2015

Choose a reason for hiding this comment

cmsbuild commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

VinInn commented Sep 25, 2015

VinInn commented Sep 27, 2015

cmsbuild commented Sep 27, 2015

deguio commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

deguio commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

davidlange6 commented Sep 29, 2015