Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Removal of 'evtgenlhc' external (EvtGenLHC91, EvtGenLHCInterface) #11595

Merged
merged 1 commit into from Oct 1, 2015
Merged

[RFC] Removal of 'evtgenlhc' external (EvtGenLHC91, EvtGenLHCInterface) #11595

merged 1 commit into from Oct 1, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Oct 1, 2015

The 'evtgenlhc' external is considered old according to Roberto
Covarelli and we should remove it.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Removal of 'evtgenlhc' external (EvtGenLHC91, EvtGenLHCInterface)
2e77e13 
The 'evtgenlhc' external is considered old according to Roberto
Covarelli and we should remove it.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 1, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

[RFC] Removal of 'evtgenlhc' external (EvtGenLHC91, EvtGenLHCInterface)

It involves the following packages:

GeneratorInterface/EvtGenInterface
GeneratorInterface/ExternalDecays

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
@inugent, @mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlt
Copy link
Contributor Author

davidlt commented Oct 1, 2015

Note, it's plugin removal. The only way to test this is to add this to IB.

@smuzaffar
Copy link
Contributor

@cmsbuild, please test

@davidlt, we should be able to test plugin removal in dev area ..... that is why we have poisoned plugin concept.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

The tests are being triggered in jenkins.

@davidlt
Copy link
Contributor Author

davidlt commented Oct 1, 2015

@smuzaffar wasn't it always getting plugin from AFS even if you delete it?

@smuzaffar
Copy link
Contributor

No, for each checked out package (in dev area) scram creates poisoned plugin cache. so if a plugin is removed then plugin manager should complain if someone tries to load it

@covarell
Copy link
Contributor

covarell commented Oct 1, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlt
Copy link
Contributor Author

davidlt commented Oct 1, 2015

Apparently 521.0 workflow is now working (something changed in a month), but still tested on machine with access to CVMFS, all fine: 1 1 1 tests passed, 0 0 0 failed. Removal of evtgenlhc does not create problems to 521.0 workflow.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

+1
Tested at: 2e77e13
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11595/8547/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

+1
Tested at: 2e77e13
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11595/8546/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11595/8547/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11595/8546/summary.html

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 1, 2015
@cmsbuild
Merge pull request #11595 from davidlt/remove-evtgenlhc
1e753a3 
[RFC] Removal of 'evtgenlhc' external (EvtGenLHC91, EvtGenLHCInterface)
@cmsbuild cmsbuild merged commit 1e753a3 into cms-sw:CMSSW_7_6_X Oct 1, 2015
@davidlt davidlt mentioned this pull request Oct 5, 2015
Closed
@ghost ghost mentioned this pull request Oct 6, 2015
Merged
@ghost
Copy link

ghost commented Oct 6, 2015

@davidlt done in cms-sw/cmsdist#1871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed generators-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidlt @cmsbuild @smuzaffar @covarell @davidlange6