76X - Fix for handling of rare case of CFEB data corruption

[barvic]

76X - The CSC Unpacker side fix for handling of rare case CFEB data corruption, which could cause assertion failure in CSC Segment RECO module.

Original issue is described at https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1391.html
Assertion failure is triggered, when number of expected time bins in CFEB data is not equal to 8.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8923/console

[cmsbuild]

A new Pull Request was created by @barvic for CMSSW_7_6_X.

76X - Fix for handling of rare case of CFEB data corruption

It involves the following packages:

EventFilter/CSCRawToDigi

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
Tested at: 60893c4
When I ran the RelVals I found an error in the following worklfows:
1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11825/8923/summary.html

[barvic]

@slava77
Is it my code changes related error or just some accidental DAS system error during testing?

[cvuosalo]

@cmsbuild please test

@barvic: Previous test failed with a transient DAS error. We'll try the test again.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8930/console

[cmsbuild]

+1
Tested at: 60893c4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11825/8930/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11825/8930/summary.html

[cvuosalo]

+1

For #11825 60893c4
Bug fix for an assertion failure and termination in the CSC unpacker. There should be no change in monitored quantities. #11821 and #11824 are the 74X and 75X versions of this PR, and they have already been approved by Reco.

The fix is satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-10-15-1100 show no significant differences, as expected. The bug was reproduced in CMSSW_7_4_14, and the bug fix was confirmed.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1