-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
76X - Fix for handling of rare case of CFEB data corruption #11825
76X - Fix for handling of rare case of CFEB data corruption #11825
Conversation
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @barvic for CMSSW_7_6_X. 76X - Fix for handling of rare case of CFEB data corruption It involves the following packages: EventFilter/CSCRawToDigi @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
-1 DAS Error 1003.0 step1 DAS Error you can see the results of the tests here: |
@slava77 |
The tests are being triggered in jenkins. |
+1 For #11825 60893c4 The fix is satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-10-15-1100 show no significant differences, as expected. The bug was reproduced in CMSSW_7_4_14, and the bug fix was confirmed. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
76X - Fix for handling of rare case of CFEB data corruption
76X - The CSC Unpacker side fix for handling of rare case CFEB data corruption, which could cause assertion failure in CSC Segment RECO module.
Original issue is described at https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1391.html
Assertion failure is triggered, when number of expected time bins in CFEB data is not equal to 8.