Updating to latest fastjet contrib Nsubjettiness

[cmsbuild]

This requires the new fastjet-contrib 1.020:

cms-sw/cmsdist#1891
Automatically ported from CMSSW_7_6_X #11791 (original by @rappoccio).

[cmsbuild]

A new Pull Request was created by @cmsbuild for CMSSW_8_0_X.

Updating to latest fastjet contrib Nsubjettiness

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @TaiSakuma, @yslai, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cvuosalo]

@cmsbuild please test with cms-sw/cmsdist#1953

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#1953
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/2/console

[cmsbuild]

+1
Tested at: 31a54c1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11911/2/summary.html

[slava77]

@cmsbuild please test with cms-sw/cmsdist#1953
maybe comparisons make it this time

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#1953
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/3/console

[cmsbuild]

+1
Tested at: 31a54c1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11911/3/summary.html

[cvuosalo]

@smuzaffar, @Degano: For the second time, comparisons have gotten stuck in Queued state. Could you please check what is wrong with the Jenkins tests?

[smuzaffar]

I think there was an issue with pr testing with cmsdist request. @Degano tried to fix it today. So let me trigger the test again

[smuzaffar]

@cmsbuild please test with cms-sw/cmsdist#1953

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#1953
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/4/console
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/5/console
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/5/console

[cvuosalo]

@smuzaffar & @Degano : Jenkins comparisons still stuck in Queued state.

[slava77]

@cmsbuild please test with cms-sw/cmsdist#1993
... keep trying until the tests land on an intel machine

looking at the console:
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/6/console has

Triggering projects: compare-root-files-short-matrix
No Files Found! Triggering Skipped.

.. and in fact there is a comparison job request
https://cmssdt.cern.ch/jenkins/job/compare-root-files-short-matrix/11526/console started on cmsbuild08
and it fails to find -AuthenticAMD directory in
https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-baseline-tests/CMSSW_8_0_X_2015-11-24-2300/slc6_amd64_gcc493/
It looks like this is expected from cms-sw/cms-bot@ff05ef6

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#1993
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/7/console
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/7/console

[slava77]

https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/7/console
... Building remotely on ... (docker slc6_amd64 slc6_amd64-GenuineIntel
better luck this time, apparently

[cmsbuild]

+1
Tested at: 31a54c1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11911/7/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11911/7/summary.html

[cvuosalo]

+1

For #11911 31a54c1

Updating Nsubjettiness for the new fastjet-contrib 1.020. There should be no change in monitored quantities. #11791 is the 76X version of this PR, and it has already been approved but not merged.

The code changes are satisfactory, and Jenkins tests with the new fastjet external against baseline CMSSW_8_0_X_2015-11-25-1100 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[slava77]

@davidlange6 @smuzaffar
this had to be merged together with the external cms-sw/cmsdist#1993
The IB in 80X is now broken

[smuzaffar]

cms-sw/cmsdist#1993 is merged now