Replace has_key with in for dictionaries

[ericvaandering]

Has been available since 2.2 and will be removed in python 3. http://legacy.python.org/dev/peps/pep-0290/#testing-dictionary-membership

Generated with the automated tool python futurize.

[cmsbuild]

A new Pull Request was created by @ericvaandering (Eric Vaandering) for CMSSW_8_0_X.

Replace has_key with in for dictionaries

It involves the following packages:

Alignment/MuonAlignmentAlgorithms
CalibMuon/DTCalibration
CondCore/TagCollection
Configuration/DataProcessing
DQM/CSCMonitorModule
DQM/Integration
DQM/SiStripMonitorClient
DQMOffline/EGamma
DQMServices/StreamerIO
DataFormats/FWLite
Documentation/ReferenceManualScripts
FWCore/ParameterSet
FWCore/PythonUtilities
FWCore/Utilities
FastSimulation/Validation
HLTrigger/Configuration
HLTrigger/Tools
HLTriggerOffline/Egamma
PhysicsTools/PatAlgos
PhysicsTools/PythonAnalysis
PhysicsTools/Utilities
RecoLocalCalo/EcalRecProducers
RecoLuminosity/LumiDB
RecoVertex/BeamSpotProducer
Utilities/RelMon
Utilities/ReleaseScripts
Validation/Performance
Validation/RecoMuon
Validation/RecoVertex
Validation/Tools

@diguida, @lveldere, @cmsdoxy, @cerminar, @Martin-Grunewald, @vanbesien, @perrotta, @civanch, @cmsbuild, @fwyzard, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @deguio, @slava77, @ggovi, @vadler, @mmusich, @ssekmen, @danduggan, @monttj, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @abbiendi, @rappoccio, @argiro, @Martin-Grunewald, @istaslis, @threus, @geoff-smith, @venturia, @pakhotin, @mmarionncern, @battibass, @makortel, @acaudron, @jhgoh, @jdolen, @ferencek, @cerati, @trocino, @rociovilar, @barvic, @wmtan, @GiacomoSguazzoni, @rovere, @VinInn, @nhanvtran, @jalimena, @schoef, @mschrode, @dgulhan, @apfeiffer1, @batinkov, @imarches, @wddgit, @ahinzmann, @gpetruc, @matt-komm, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9086/console

[lveldere]

+1

[Dr15Jones]

+1

[cmsbuild]

-1

Tested at: 50ca38b
I found errors in the following unit tests:

---> test TestFWCoreIntegrationStandalone had ERRORS
---> test unitTestsGroup_4 had ERRORS
---> test unitTestsGroup_1 had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12004/9086/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e09f3bf
656a234
548ffa4
b0396f0
e295eac
a9d34ed
e87efd3
d3ba289
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12004/9086/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12004/9086/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12004/9086/summary.html

[slava77]

+1

for #12004 50ca38b

• changes are as described
• jenkins tests pass (ignoring known unit test failures); comparisons with the baseline show no differences

[fwyzard]

+1