Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed save digi behavior to check for end of list #12038

Merged
merged 2 commits into from
Oct 24, 2015

Conversation

hardenbr
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hardenbr for CMSSW_7_5_X.

fixed save digi behavior to check for end of list

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

please test

@Martin-Grunewald
Copy link
Contributor

ahh too early... - needs the const & fix...

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #12038 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlt
Copy link
Contributor

davidlt commented Oct 24, 2015

Add ref to issue: #11982

davidlange6 added a commit that referenced this pull request Oct 24, 2015
fixed save digi behavior to check for end of list
@davidlange6 davidlange6 merged commit d02df4e into cms-sw:CMSSW_7_5_X Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants