Revision of snapshotTime handling in HLT and new Run2 MC GT with ES fixes #12168

diguida · 2015-10-29T13:58:22Z

Summary of Changes for HLT Testing

Revision of snapshotTime handling in HLT: no longer use/set a global snapshotTime but move to a per-payload snapshotTime, set to the time of PR #12095

Summary of Changes in the GT

Originally in #12114 commit mmusich@bee66c2

RunII Simulation

RunII Ideal scenario : 76X_mcRun2_design_v11 as 76X_mcRun2_design_v10 with the following changes:
- updated Preshower pedestals as per pedestal run in low gain taken in Run2015D
- updated Preshower Zero suppression thresholds with 6 ADC
RunII Asymptotic scenario : 76X_mcRun2_asymptotic_v11 as 76X_mcRun2_asymptotic_v10 with the following changes:
- updated Preshower bad channels as per Run2015D
- updated Preshower pedestals as per pedestal run in low gain taken in Run2015D
- updated Preshower Zero suppression thresholds with 6 ADC
- RunII Startup scenario : 76X_mcRun2_startup_v11 as 76X_mcRun2_startup_v10 with the following changes:
- updated Preshower bad channels as per Run2015D
- updated Preshower pedestals as per pedestal run in low gain taken in Run2015D
- updated Preshower Zero suppression thresholds with 6 ADC
RunII Heavy Ions scenario : 76X_mcRun2_HeavyIon_v11 as 76X_mcRun2_HeavyIon_v10 with the following changes:
- updated Preshower bad channels as per Run2015D
- updated Preshower pedestals as per pedestal run in low gain taken in Run2015D
- updated Preshower Zero suppression thresholds with 6 ADC

cmsbuild · 2015-10-29T14:01:18Z

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_6_X.

Revision of snapshotTime handling in HLT and new Run2 MC GT with ES fixes

It involves the following packages:

Configuration/AlCa
Configuration/HLT
HLTrigger/Configuration

@perrotta, @cmsbuild, @diguida, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

diguida · 2015-10-29T14:01:30Z

please test

cmsbuild · 2015-10-29T14:06:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9327/console

diguida · 2015-10-29T14:53:14Z

@cmsbuild please acknowledge changes

davidlange6 · 2015-10-29T14:55:07Z

@cmsbuild, please test
I will close #12114

cmsbuild · 2015-10-29T14:56:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9328/console

cmsbuild · 2015-10-29T14:56:15Z

Pull request #12168 was updated. @perrotta, @cmsbuild, @diguida, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich can you please check and sign again.

cmsbuild · 2015-10-29T15:11:13Z

Pull request #12168 was updated. @perrotta, @cmsbuild, @diguida, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich can you please check and sign again.

diguida · 2015-10-29T15:11:24Z

please test

cmsbuild · 2015-10-29T15:16:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9332/console

cmsbuild · 2015-10-29T19:12:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12168/9328/summary.html

cmsbuild · 2015-10-29T19:12:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12168/9332/summary.html

diguida · 2015-10-29T22:33:19Z

Interesting: the bot sees the failure (timeout) here, but the latest test is actually fine.

diguida · 2015-10-30T09:34:04Z

@emanueledimarco @shervin86
please give a look here (sample plot) and here (sample plot) and confirm that the changes of the ES conditions:

bad channels
pedestals
ZS thresholds

go in the right direction.

shervin86 · 2015-10-30T09:35:41Z

Adding ES experts: Arabella and Ming.

                        Shervin

On Fri, 30 Oct 2015, Salvatore Di Guida wrote:

Date: Fri, 30 Oct 2015 10:34:07 +0100
From: Salvatore Di Guida notifications@github.com
Reply-To: cms-sw/cmssw
<reply+0045c225351019b1e97f714fd6ebb1fd52a13bf6438e7a2f92cf00000001124afb8
f92a169ce06cc58ed@reply.github.com>
To: cms-sw/cmssw cmssw@noreply.github.com
Cc: shervin86 shervin@cern.ch
Subject: Re: [cmssw] Revision of snapshotTime handling in HLT and new Run2 MC
GT with ES fixes (#12168)

@emanueledimarco @shervin86
please give a look here (sample plot) and here (sample plot) and confirm that the changes of the ES conditions:

bad channels

pedestals

ZS thresholds

go in the right direction.

Reply to this email directly or view it on GitHub:
#12168 (comment)

…customisation. As a default/starting point, use the snapshot time set to the time of the PR cms-sw#12095.

diguida · 2015-10-30T09:39:36Z

@cmsbuild please acknowledge changes
Amended commits for fixing the typo noted by @Martin-Grunewald and for making the bot happy.

cmsbuild · 2015-10-30T09:41:49Z

Pull request #12168 was updated. @perrotta, @cmsbuild, @diguida, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich can you please check and sign again.

diguida · 2015-10-30T09:41:58Z

please test

cmsbuild · 2015-10-30T09:46:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9371/console

shervin86 · 2015-10-30T10:04:26Z

The changes are expected, more low energy recHits as due to the lower ZS threshold and realistic noise per each strip

Arabella

On 30 Oct 2015, at 10:35, Shervin shervin@cern.ch wrote:

Adding ES experts: Arabella and Ming.
                      Shervin
On Fri, 30 Oct 2015, Salvatore Di Guida wrote:

Date: Fri, 30 Oct 2015 10:34:07 +0100
From: Salvatore Di Guida notifications@github.com
Reply-To: cms-sw/cmssw
<reply+0045c225351019b1e97f714fd6ebb1fd52a13bf6438e7a2f92cf00000001124afb8
f92a169ce06cc58ed@reply.github.com>
To: cms-sw/cmssw cmssw@noreply.github.com
Cc: shervin86 shervin@cern.ch
Subject: Re: [cmssw] Revision of snapshotTime handling in HLT and new Run2 MC
GT with ES fixes (#12168)
@emanueledimarco @shervin86
please give a look here (sample plot) and here (sample plot) and confirm that the changes of the ES conditions:

bad channels

pedestals

ZS thresholds

go in the right direction.

Reply to this email directly or view it on GitHub:
#12168 (comment)

diguida · 2015-10-30T10:32:25Z

@shervin86 thanks for confirming.
As soon as tests are ok, they can go in.

cmsbuild · 2015-10-30T12:09:02Z

+1
Tested at: 72269b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12168/9371/summary.html

davidlange6 · 2015-10-30T13:05:53Z

merging and will look at the comparisons once they finish..

Revision of snapshotTime handling in HLT and new Run2 MC GT with ES fixes

Martin-Grunewald · 2015-10-30T13:19:52Z

+1

cmsbuild · 2015-10-30T16:48:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12168/9371/summary.html

Revision of snapshotTime handling in HLT

f2852f3

diguida mentioned this pull request Oct 29, 2015

Revision of snapshotTime handling in HLT #12095

Closed

cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 29, 2015

cmsbuild added hlt-pending alca-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 29, 2015

diguida mentioned this pull request Oct 29, 2015

Adding label HLT for PFCalibrationRcd #12114

Closed

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2015

diguida force-pushed the HLT_snapshotTime_AlCa_newMCGT branch from 662a6cc to 42745a1 Compare October 29, 2015 14:52

cmsbuild added tests-pending and removed tests-started labels Oct 29, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2015

diguida force-pushed the HLT_snapshotTime_AlCa_newMCGT branch from 42745a1 to c2124a3 Compare October 29, 2015 15:09

cmsbuild added tests-pending and removed tests-started labels Oct 29, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 29, 2015

Salvatore Di Guida and others added 2 commits October 30, 2015 10:38

Add the possibiity to change all the snapshot times in the L1T menus …

56c816e

…customisation. As a default/starting point, use the snapshot time set to the time of the PR cms-sw#12095.

Fixing ES bad channels, pedestals and ZS thresholds

72269b7

diguida force-pushed the HLT_snapshotTime_AlCa_newMCGT branch from c2124a3 to 72269b7 Compare October 30, 2015 09:38

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Oct 30, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 30, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 30, 2015

davidlange6 added a commit that referenced this pull request Oct 30, 2015

Merge pull request #12168 from diguida/HLT_snapshotTime_AlCa_newMCGT

27b1da2

Revision of snapshotTime handling in HLT and new Run2 MC GT with ES fixes

davidlange6 merged commit 27b1da2 into cms-sw:CMSSW_7_6_X Oct 30, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revision of snapshotTime handling in HLT and new Run2 MC GT with ES fixes #12168

Revision of snapshotTime handling in HLT and new Run2 MC GT with ES fixes #12168

diguida commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

diguida commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

diguida commented Oct 29, 2015

davidlange6 commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

diguida commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

diguida commented Oct 29, 2015

diguida commented Oct 30, 2015

shervin86 commented Oct 30, 2015

diguida commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

diguida commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

shervin86 commented Oct 30, 2015

diguida commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

davidlange6 commented Oct 30, 2015

Martin-Grunewald commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

Revision of snapshotTime handling in HLT and new Run2 MC GT with ES fixes #12168

Revision of snapshotTime handling in HLT and new Run2 MC GT with ES fixes #12168

Conversation

diguida commented Oct 29, 2015

Summary of Changes for HLT Testing

Summary of Changes in the GT

RunII Simulation

cmsbuild commented Oct 29, 2015

diguida commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

diguida commented Oct 29, 2015

davidlange6 commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

diguida commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

cmsbuild commented Oct 29, 2015

diguida commented Oct 29, 2015

diguida commented Oct 30, 2015

shervin86 commented Oct 30, 2015

diguida commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

diguida commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

shervin86 commented Oct 30, 2015

diguida commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

davidlange6 commented Oct 30, 2015

Martin-Grunewald commented Oct 30, 2015

cmsbuild commented Oct 30, 2015