-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing-, inactive-, valid-hits and clusterChargePerCm TkMaps #12289
add missing-, inactive-, valid-hits and clusterChargePerCm TkMaps #12289
Conversation
A new Pull Request was created by @rrabadan (Raul Rabadan) for CMSSW_7_5_X. add missing-, inactive-, valid-hits and clusterChargePerCm TkMaps It involves the following packages: DQM/SiStripMonitorClient @cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks. |
Pull request #12289 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again. |
please test |
please submit to 76x and 80x as well. |
The tests are being triggered in jenkins. |
Pull request #12289 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again. |
seems ok to me |
-1 runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log 135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log 140.53 step2 runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log you can see the results of the tests here: |
please test |
The tests are being triggered in jenkins. |
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
add missing-, inactive-, valid-hits and clusterChargePerCm TkMaps
valid, missing and inactive recHit TrackerHistoMaps added.
inclusiveClusterCharge, ClusterChargePerCMfromOrigin and ClusterChargePerCMfromTrack TkHistoMaps also added.
inclusiveClusterCharge and ClusterChargePerCMfromTrack configurable.
SiStripDQM_OfflineTkMap_Template_cfg_DB.py updated to create the corresponding new TkMaps