Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing-, inactive-, valid-hits and clusterChargePerCm TkMaps #12289

Merged
merged 3 commits into from
Nov 16, 2015

Conversation

rrabadan
Copy link
Contributor

@rrabadan rrabadan commented Nov 6, 2015

valid, missing and inactive recHit TrackerHistoMaps added.
inclusiveClusterCharge, ClusterChargePerCMfromOrigin and ClusterChargePerCMfromTrack TkHistoMaps also added.
inclusiveClusterCharge and ClusterChargePerCMfromTrack configurable.
SiStripDQM_OfflineTkMap_Template_cfg_DB.py updated to create the corresponding new TkMaps

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2015

A new Pull Request was created by @rrabadan (Raul Rabadan) for CMSSW_7_5_X.

add missing-, inactive-, valid-hits and clusterChargePerCm TkMaps

It involves the following packages:

DQM/SiStripMonitorClient
DQM/SiStripMonitorCluster
DQM/SiStripMonitorTrack

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2015

Pull request #12289 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Nov 10, 2015

please test

@deguio
Copy link
Contributor

deguio commented Nov 10, 2015

please submit to 76x and 80x as well.
thanks,
F.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9573/console

@cmsbuild
Copy link
Contributor

Pull request #12289 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Nov 10, 2015

seems ok to me

@cmsbuild
Copy link
Contributor

-1
Tested at: 96cdec9
When I ran the RelVals I found an error in the following worklfows:
4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12289/9573/summary.html

@deguio
Copy link
Contributor

deguio commented Nov 12, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9692/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12289/9692/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@deguio
Copy link
Contributor

deguio commented Nov 16, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 16, 2015
add missing-, inactive-, valid-hits and clusterChargePerCm TkMaps
@cmsbuild cmsbuild merged commit 644cc5f into cms-sw:CMSSW_7_5_X Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants