-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New HCalTower cleaner including rechits #12334
Conversation
A new Pull Request was created by @safarzad for CMSSW_8_0_X. New HCalTower cleaner including rechits It involves the following packages: HLTrigger/JetMET @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. |
Hi, You also need to declare it as a plugin using the Fw macros. |
I do not know what is Fw macros |
it is only a new module that if it is in cmssw we will be able to go further and create a JIRA ticket for HLT cfg to use this module in 2016. |
You will not be able to use it with cmsRun if it is not declared as a plugin: |
please test |
The tests are being triggered in jenkins. |
Pull request #12334 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
New HCalTower cleaner including rechits
New module includes rechit filter to be applied in 2016 menus