Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New HCalTower cleaner including rechits #12334

Merged
merged 2 commits into from Nov 19, 2015

Conversation

safarzad
Copy link
Contributor

New module includes rechit filter to be applied in 2016 menus

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @safarzad for CMSSW_8_0_X.

New HCalTower cleaner including rechits

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

Hi,

You also need to declare it as a plugin using the Fw macros.

@safarzad
Copy link
Contributor Author

I do not know what is Fw macros

@safarzad
Copy link
Contributor Author

it is only a new module that if it is in cmssw we will be able to go further and create a JIRA ticket for HLT cfg to use this module in 2016.

@Martin-Grunewald
Copy link
Contributor

You will not be able to use it with cmsRun if it is not declared as a plugin:
Add it to https://github.com/cms-sw/cmssw/blob/CMSSW_8_0_X/HLTrigger/JetMET/plugins/SealModule.cc - see there how this is done for the other modules.
(and read up on the FwEDM twikis on how to declare new plugins).

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9580/console

@cmsbuild
Copy link
Contributor

Pull request #12334 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 19, 2015
New HCalTower cleaner including rechits
@davidlange6 davidlange6 merged commit 41e8e3c into cms-sw:CMSSW_8_0_X Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants