Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssoByHits with GEM hits porting 8XY #12382

Merged
merged 8 commits into from Dec 1, 2015

Conversation

calabria
Copy link
Contributor

This PR contains the new module needed to associate the GEM tracking recHits (GEMHitAssociator) and the all the changes needed in the AssociatorByHits to make it associate also GEM tracking recHits. The association of GEM hits is disabled by default to avoid problems when the GEM detectors are not present in the geometry scenario. Moreover a new plot representing the averange number of GEM tracking recHits vs eta hs been added in the MuonTrackValidator. It is not filled by default, it has to be switched on when GEM detectors are present in the simulation. I checked the code with the following runTheMatrix command and all tests ended successfully: runTheMatrix.py -l limited -i all (with the use of GEM disabled, but I tested it also with GEM hits present and GEM association enabled without problems).

Same content as #11962 in 76X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @calabria (Cesare) for CMSSW_8_0_X.

It involves the following packages:

SimMuon/MCTruth
Validation/RecoMuon

@civanch, @danduggan, @mdhildreth, @cmsbuild, @deguio, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar, @abbiendi, @trocino, @jhgoh, @battibass this is something you requested to watch as well.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/L2's to mark it as on hold
  • merge: L1 to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Nov 12, 2015

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Nov 13, 2015

+1

@calabria
Copy link
Contributor Author

@deguio @Degano @davidlange6 can this PR be approved and merged? thanks

@deguio
Copy link
Contributor

deguio commented Nov 30, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 1, 2015
@cmsbuild cmsbuild merged commit e63757a into cms-sw:CMSSW_8_0_X Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants