Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update track-PV and track-jet associations in tracking validation, add more collections to standalone mode #12414

Merged
merged 6 commits into from Nov 21, 2015

Conversation

makortel
Copy link
Contributor

This PR contains the following updates to tracking validation

  • Associate tracks to PV by simple dz(PV) cut instead of the PV sorter (in "fromPV" variants of MultiTrackValidator)
    • Main motivation is to be able to do the same association with tracking-only information, and whether running (tracking-only) RECO on the fly or using RECO+DIGI as an input
  • Monitor the tracks from AK4 PFJet constituents instead of those in cone of DeltaR < 0.4
    • It is more interesting to us to monitor what exactly gets clustered
  • For standalone mode (not used in RelVals), add iteration selections using originalAlgo and algoMask
  • Generalize the configuration of monitored iterations such that it will be straightforward to customize the iterations for e.g. Phase1 tracking with eras

Tested in CMSSW_8_0_X_2015-11-12-1100, expecting changes in Tracking/TrackFromPV, Tracking/TrackFromPVAllTP, and Tracking/Track/cutsRecoAK4PFJets_trackingParticleRecoAsssociation DQM folders.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

Validation/RecoTrack

@cmsbuild, @danduggan, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/L2's to mark it as on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@VinInn
Copy link
Contributor

VinInn commented Nov 13, 2015

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9708/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@makortel
Copy link
Contributor Author

ping

@deguio
Copy link
Contributor

deguio commented Nov 19, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 21, 2015
Update track-PV and track-jet associations in tracking validation, add more collections to standalone mode
@cmsbuild cmsbuild merged commit c7022b1 into cms-sw:CMSSW_8_0_X Nov 21, 2015
@makortel makortel deleted the trackingValidationFromPVUpdate branch October 20, 2016 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants