Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VBF filters for QCD sample requested by VBF InvisibleHiggs analysis #12421

Merged
merged 2 commits into from
Nov 23, 2015
Merged

VBF filters for QCD sample requested by VBF InvisibleHiggs analysis #12421

merged 2 commits into from
Nov 23, 2015

Conversation

chayanit
Copy link

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @chayanit (Chayanit Asawatangtrakuldee) for CMSSW_8_0_X.

It involves the following packages:

GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/L2's to mark it as on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@chayanit
Copy link
Author

Dear GEN conveners,

Could you help me merge these filters needed for QCD_VBFFilter samples?

Thanks in advance.
Chayanit

@govoni
Copy link
Contributor

govoni commented Nov 19, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9841/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: 87a8555
I found an error when building:

>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-18-2200/src/GeneratorInterface/GenFilters/src/SealModule.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-18-2200/src/GeneratorInterface/GenFilters/src/TotalKinematicsFilter.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-18-2200/src/GeneratorInterface/GenFilters/src/TwoVBGenFilter.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-18-2200/src/GeneratorInterface/GenFilters/src/UEDMultiLeptonFilter.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-18-2200/src/GeneratorInterface/GenFilters/src/VBFGenJetFilter.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-18-2200/src/GeneratorInterface/GenFilters/src/VBFGenJetFilter.cc:1:66: fatal error: CMSSW_VBFHToInv/GenFilters/interface/VBFGenJetFilter.h: No such file or directory
 #include "CMSSW_VBFHToInv/GenFilters/interface/VBFGenJetFilter.h"
                                                                  ^
compilation terminated.
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-18-2200/src/GeneratorInterface/GenFilters/src/XtoFFbarFilter.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-18-2200/src/GeneratorInterface/GenFilters/src/VBFGenJetFilter.cc:1:66: fatal error: CMSSW_VBFHToInv/GenFilters/interface/VBFGenJetFilter.h: No such file or directory


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12421/9841/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #12421 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please check and sign again.

@govoni
Copy link
Contributor

govoni commented Nov 19, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9844/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 23, 2015
VBF filters for QCD sample requested by VBF InvisibleHiggs analysis
@davidlange6 davidlange6 merged commit a0a33ae into cms-sw:CMSSW_8_0_X Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants