Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabling LogWarning in HadronAndPartonSelector (76X) #12436

Conversation

ferencek
Copy link
Contributor

Backport of #12435.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_6_X.

It involves the following packages:

PhysicsTools/JetMCAlgos

@cmsbuild, @vadler, @davidlange6, @monttj can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@slava77
Copy link
Contributor

slava77 commented Dec 2, 2015

@cmsbuild please test
to see if this is not noisy

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10091/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@ferencek
Copy link
Contributor Author

ferencek commented Jan 7, 2016

@davidlange6, just checking if there was a specific reason not to merge this one. Its 80X equivalent was successfully merged several weeks ago. Thanks

davidlange6 added a commit that referenced this pull request Jan 24, 2016
…ning_from-CMSSW_7_6_1

Re-enabling LogWarning in HadronAndPartonSelector (76X)
@davidlange6 davidlange6 merged commit 698af4e into cms-sw:CMSSW_7_6_X Jan 24, 2016
cmsbuild added a commit that referenced this pull request Jan 24, 2016
@ferencek ferencek deleted the HadronAndPartonSelectorLogWarning_from-CMSSW_7_6_1 branch January 24, 2016 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants