bsunanda:Run2-hcx50 Correct hardcoded calibration for HcalTriggerTower

[bsunanda]

Applicable for PhaseI and PhaseII scenario

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9750/console

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

It involves the following packages:

CalibCalorimetry/HcalPlugins
Geometry/HcalCommonData

@civanch, @diguida, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[cmsbuild]

+1
Tested at: 50576b2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12438/9750/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12438/9750/summary.html

[ianna]

+1

[davidlange6]

I enjoy changing one set of hardcoded numbers to another as much as anyone.. but maybe we can at least start to define 41, 72, 1 and 3 in some central place to make this code more understandable?

[bsunanda]

The maximum values can best be defined in the DetId class where we reserve a certain # of bits to define ieta, iphi, ... But I am waiting PR for HcalDetId changes to be accepted first before doing this.

---

From: David Lange [notifications@github.com]
Sent: 17 November 2015 12:00
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx50 Correct hardcoded calibration for HcalTriggerTower (#12438)

I enjoy changing one set of hardcoded numbers to another as much as anyone.. but maybe we can at least start to define 41, 72, 1 and 3 in some central place to make this code more understandable?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12438#issuecomment-157337359.

[bsunanda]

@diguida @mmusich Could you please take a look and approve. This restores the breaking of a few unit tests

[diguida]

+1
We second @davidlange6 proposal to avoid magic numbers and put them in a centralised place (HcalDetId or HCAL topology definition look suitable candidates).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Pull request #12438 was updated. @civanch, @diguida, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @mmusich, @davidlange6 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10116/console

[cmsbuild]

+1
Tested at: dba1207
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12438/10116/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12438/10116/summary.html

[civanch]

+1

[diguida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1