-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phase1Pixel era harvesting additions #12440
phase1Pixel era harvesting additions #12440
Conversation
…ence if the phase 1 pixel era is active
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_8_0_X. It involves the following packages: DQM/SiPixelCommon @cmsbuild, @danduggan, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
…anges phase1Pixel era harvesting additions
Another tranche of
phase1Pixel
era changes. This one is for Harvesting changes, equivalent to the customise_harvesting function.There should be no change whatsoever unless the Run2_2017 era is active (the only top-level era that contains phase1Pixel).
@atricomi, @delaere - In DQM/SiPixelCommon/python/SiPixelOfflineDQM_client_cff.py there is also a
sipixelPhase1Client
analyzer, which is now redundant (and correspondingPixelOfflinePhase1DQMClient
sequence). I didn't take them out though because I don't know what else relies on them, and you also might prefer to do your configuration using those.@boudoul