Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread-safe ED Analyzers #12461

Merged
merged 5 commits into from
Nov 19, 2015
Merged

Thread-safe ED Analyzers #12461

merged 5 commits into from
Nov 19, 2015

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Nov 17, 2015

  • Migrate to thread safe analyzer

@ianna
Copy link
Contributor Author

ianna commented Nov 17, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 17, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9779/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_0_X.

It involves the following packages:

Geometry/CSCGeometry
Geometry/EcalTestBeam
Geometry/HcalTowerAlgo

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @argiro this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@ianna
Copy link
Contributor Author

ianna commented Nov 17, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9780/console

Dr15Jones
Dr15Jones reviewed Nov 17, 2015
View reviewed changes
Geometry/EcalTestBeam/test/ee/SurveyToTransforms.cc
public:
SurveyToTransforms( const edm::ParameterSet& );
~SurveyToTransforms();
class SurveyToTransforms : public edm::one::EDAnalyzer<> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is using the TFileService then you must declare a 'shared resource'. For details see

https://twiki.cern.ch/twiki/bin/view/CMSPublic/FWMultithreadedAnalysisEDAnalyzer#Using_TFileService

@cmsbuild
Copy link
Contributor

+1
Tested at: f6d66d2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12461/9780/summary.html

@cmsbuild
Copy link
Contributor

+1
Tested at: 51e6af8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12461/9779/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12461/9780/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12461/9779/summary.html

@Dr15Jones
Copy link
Contributor

-1

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 74c2d89
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12461/9805/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: 74c2d89
The relvals timed out after 2 hours.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12461/9806/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12461/9805/summary.html

@smuzaffar
Copy link
Contributor

please test
@ianna, previous tests were running for commit 74c2d89 which is a commit before your last change. I have request to re-start the tests and it should now trigger tests based on your latests changes i.e. ee0db90

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: ee0db90
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12461/9809/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12461/9809/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 19, 2015
@davidlange6
Merge pull request #12461 from ianna/geometry-analyzers
d14a8e0 
Thread-safe ED Analyzers
@davidlange6 davidlange6 merged commit d14a8e0 into cms-sw:CMSSW_8_0_X Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed geometry-approved orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@ianna @cmsbuild @Dr15Jones @smuzaffar @davidlange6