-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Hcal Object - HcalQIEType #12473
Conversation
A new Pull Request was created by @walterjr (Walter Alda) for CMSSW_8_0_X. It involves the following packages: CondFormats/DataRecord @diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
The tests are being triggered in jenkins. |
@walterjr @abdoulline you need to edit |
Walter, please modify your branch the way Marco has asked: CondCore/Utilities/src/CondDBFetch.cc to add HcalQIETypes (the same way - for instance - as HcalRecoParams is added). |
@mmusich @abdoulline
For now is not necessary to change the CondCore/Utilities files because Step (1) do not take any "action" using the DB. All necessary changes to handle with the DB will be taken on Step (2). |
Walter, (let Marco correct me, if I'm wrong) - BTW, I presume you mean not RelVal, but runTheMatrix test in your 2), 4). S. On Wed, 18 Nov 2015, Walter Alda wrote:
|
Walter, So that all the code changes would be submitted (without breaking runTheMatrix tests) at once? |
Salavat, Local test with (1)+(2) shows that the runTheMatrix test do not break. |
Walter, Once (1)+(2) will be approved/merged, DB experts can proceed with preparing new table in DB for payload. |
please test |
The tests are being triggered in jenkins. |
+1
|
ping @ggovi |
@ggovi - could you, please, approve it... |
@ggovi - could you, please, approve it ? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
First step to create a new object on the Data Base.
This PR only create the object (or class) for the next step (implementation on the code to create tags on the DB using the new object).
This DB container will provide per-HCAL-readout flag of the FE QIE electronics type for choosing a corresponding ADC coder in DIGI/RECO.
It involves the following packages:
CondFormats/DataRecord
CondFormats/HcalObjects