Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Pythia8 Filter for genparticles HT #12516

Merged
merged 2 commits into from
Nov 25, 2015

Conversation

alefisico
Copy link
Contributor

Hi,

I need to include this filter for the generation of our signal. It only calculates the HT of generated particles from pythia8. I think for the actual generation I need it to be backported to 7_1_X ( the release that will actually be used) and 7_6_X as the release the output will be in.

Please let me know if you have any question.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for CMSSW_8_0_X.

It involves the following packages:

GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@bendavid
Copy link
Contributor

The filter is only needed in 80x and 71x (you don't need it in 76x, since only the digi-reco will be done there)

If you only use the status 23 particles, then you will end up with ~exactly the same result as if you just applied the HT cuts at the madgraph level.

Instead I think what you will want to do is run the genparticle and genjet producers and then filter on the HT of the GenJet collection (This is as close as you can get to reconstruction-level jets)

@alefisico
Copy link
Contributor Author

Hi Josh, I cannot applied an HT cut at madgraph level since the quarks coming from the stops are not generated in madgraph but in pythia8. I tried to apply an HT cut in madgraph but it is applied only to the extra partons. That is the reason I have to use this filter after pythia8.

@bendavid
Copy link
Contributor

Ah ok yes you're right. If you do it like this then indeed the HT calculation will include the stop decay products.

So indeed what is here should be ok and does address the original issue.

On the other hand, since you already have to run pythia, you COULD do the filtering at genjet level, and this would be closer to the kinematics of the reconstructed jets.

Let me know if you want to try that or if you're happy with what you have here, in which case I'll just merge it.

@alefisico
Copy link
Contributor Author

yes, we checked it with genJets. You can see the plot here, where I am comparing the samples without extra partons, with extra partons and without this filter and with this filter, using AK4 genJets:
rawak4ht_all
basically, by applying this HT filter I think we are fine.

@bendavid
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9893/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 25, 2015
adding Pythia8 Filter for genparticles HT
@cmsbuild cmsbuild merged commit 7892dbd into cms-sw:CMSSW_8_0_X Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants