-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small bugfixes in alignment workflows #12523
Conversation
hroskes
commented
Nov 20, 2015
- fix the bug I mentioned in the alignment meeting yesterday in the systematic misalignment tool
- new geometry comparison for applying "misalignment" with no shift, I think what's left is rounding errors:
- new geometry comparison for applying "misalignment" with no shift, I think what's left is rounding errors:
- fix bug that Gregor mentioned last week, of not copying png and pdf files
- a couple of other minor bugs
… compared to the input
A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_8_0_X. It involves the following packages: Alignment/OfflineValidation @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Small bugfixes in alignment workflows
Backport of #12523: Small bugfixes in alignment workflows
Backport of #12523: Small bugfixes in alignment workflows
Backport of #12523: Small bugfixes in alignment workflows