Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HcalTrigTowerDetId and read/dump changes for 1x1 HF TP #12529

Merged

Conversation

lihux25
Copy link
Contributor

@lihux25 lihux25 commented Nov 20, 2015

] HcalTrigTowerDetId change to decode depth to version + real depth (for input depth>=10)
] In the HcalDbASCIIIO and HcalText2DetIdConverter, make changes to have consistent read/dump results for uHTR TP

] HcalTrigTowerDetId change to decode depth to version + real depth (for input depth>=10)
] In the HcalDbASCIIIO and HcalText2DetIdConverter, make changes to have consistent read/dump results for uHTR TP
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lihux25 (Hongxuan Liu) for CMSSW_8_0_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibFormats/HcalObjects
DataFormats/HcalDetId

@civanch, @diguida, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@abdoulline
Copy link

@civanch, @diguida, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @davidlange6
Could you start test, please?

@mmusich
Copy link
Contributor

mmusich commented Nov 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9895/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@abdoulline
Copy link

@civanch, @diguida, @mmusich
Could you, please, approve it. HCAL is going to submit LUTs generation update for 1x1 HF TPs, which uses this additional/updated functionality...

@mmusich
Copy link
Contributor

mmusich commented Nov 24, 2015

+1

@civanch
Copy link
Contributor

civanch commented Nov 24, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 25, 2015
…_80X

HcalTrigTowerDetId and read/dump changes for 1x1 HF TP
@cmsbuild cmsbuild merged commit 28f1035 into cms-sw:CMSSW_8_0_X Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants