-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HcalTrigTowerDetId and read/dump changes for 1x1 HF TP #12529
HcalTrigTowerDetId and read/dump changes for 1x1 HF TP #12529
Conversation
] HcalTrigTowerDetId change to decode depth to version + real depth (for input depth>=10) ] In the HcalDbASCIIIO and HcalText2DetIdConverter, make changes to have consistent read/dump results for uHTR TP
A new Pull Request was created by @lihux25 (Hongxuan Liu) for CMSSW_8_0_X. It involves the following packages: CalibCalorimetry/HcalAlgos @civanch, @diguida, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@civanch, @diguida, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @davidlange6 |
please test |
The tests are being triggered in jenkins. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
…_80X HcalTrigTowerDetId and read/dump changes for 1x1 HF TP
] HcalTrigTowerDetId change to decode depth to version + real depth (for input depth>=10)
] In the HcalDbASCIIIO and HcalText2DetIdConverter, make changes to have consistent read/dump results for uHTR TP