Make edmNew::DetSetVector conform to CMSSW standards #12553
Conversation
-Changed member data names to start with m_ in the cases where the change would not affect storage. -Removed use of const_cast and use mutable with thread attributes. This allows the static analyzer to understand the code. -Changed USE_ATOMIC to DSVN_USE_ATOMIC to avoid possible name clashes -Hid function definitions in the cases where ROOT 6 is not supposed to see the implementation. This avoids C++ one definition rule violations.
In order to keep threading technologies consistent over all tests, switched to using std::thread.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X. It involves the following packages: DataFormats/Common @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
core-approved
fully-signed
tests-started
and removed
core-pending
pending-signatures
tests-pending
labels
|
@Dr15Jones thanks. |
|
+1 |
Make edmNew::DetSetVector conform to CMSSW standards
Minor refactoring of the code to make it closer to CMSSW standards. Member data names for stored classes were not changed since that would require schema evolution.