-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PackedCandidate vertex to post-packed value #12558
Fix PackedCandidate vertex to post-packed value #12558
Conversation
Otherwise it will not be set to the unpacked values in unpackVtx().
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X. It involves the following packages: DataFormats/PatCandidates @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison is ready @slava77 there are some missing matrix maps:
|
By the way, although this fix only affects the "on the fly packed+unpacked" values (i.e. should have no impact on the packed values on the disk), should it be back-ported to 76X for the MiniAOD v2 campaign? I guess the only real effect would be on whether tracking validation reports mention or not the discrepancies fixed here. |
76X backport is #12588. |
Fix PackedCandidate vertex to post-packed value
I suspect #12367 was not enough to fully restore the 760pre7 behaviour of PackedCandidate packing given my 800per2 validation report
https://hypernews.cern.ch/HyperNews/CMS/get/relval/4324/16.html
Deleting also
vertex_
inpackBoth()
seems to make a difference in the dxy/dz and track reference point histograms to the right direction.Tested in 800pre2.
@davidlange6 @arizzi @gpetruc