bsunanda:Run2-alca30 Update the codes for IsoTrack and Muon in view of suggestion during calibration activity #12573

bsunanda · 2015-11-25T21:31:30Z

IsoTrack and Muons used in HB/HE went through substantial modifications in view of the recent exercise on HCAL calibration. The modified codes are committed here

…alibration activity

bsunanda · 2015-11-25T21:32:58Z

@cmsbuild Please test

cmsbuild · 2015-11-25T21:36:12Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9959/console

cmsbuild · 2015-11-25T21:36:13Z

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

It involves the following packages:

Calibration/HcalCalibAlgos
Calibration/IsolatedParticles

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

bsunanda · 2015-11-25T21:39:41Z

@diguida @mmusich I can summarize the requirement in an ALCA meeting

cmsbuild · 2015-11-25T23:13:50Z

+1
Tested at: ed040e4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12573/9959/summary.html

cmsbuild · 2015-11-26T01:03:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12573/9959/summary.html

mmusich · 2015-11-26T09:55:44Z

@bsunanda ok, we'll reserve a slot at the next meeting. Thanks

bsunanda · 2015-11-30T15:33:08Z

@cmsbuild Please test

cmsbuild · 2015-11-30T15:38:38Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10022/console

cmsbuild · 2015-11-30T15:38:39Z

Pull request #12573 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

cmsbuild · 2015-12-07T20:26:53Z

Pull request #12573 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

bsunanda · 2015-12-07T20:28:40Z

@cmsbuild Please test

cmsbuild · 2015-12-07T20:28:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10188/console

cmsbuild · 2015-12-07T22:07:56Z

+1
Tested at: 5398dd8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12573/10188/summary.html

cmsbuild · 2015-12-07T23:12:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12573/10188/summary.html

diguida · 2015-12-10T11:30:21Z

Calibration/HcalCalibAlgos/plugins/HcalIsoTrkAnalyzer.cc

+      }
+    }
+  } 
+  if (t_goodPV == 0 && beamSpotH.isValid()) {
    leadPV = beamSpotH->position();
  }


@bsunanda IIUC the logic is the following: you want to

define a primary vertex selection: being not fake and with at least 5 dof

find the first occurrence of a primary vertex passing the selection in a valid non-zero-sized collection of reconstructed vertices, and extract its position

enumerate all the vertices in the collection passing the selection;

if no selection passed, use the BeamSpot position.

Maybe the code is not optimal here, but can go in, as of now.

diguida · 2015-12-10T19:37:44Z

+1
Conditional approval. The features presented are implemented:

move Calibration/HcalCalibAlgos/src/AnalyzerMinbias.cc to Calibration/HcalCalibAlgos/plugins/AnalyzerMinbias.cc (this was most likely left over by some commits in the branch or previous PR);
use TFileService in Calibration/HcalCalibAlgos/plugins/RecAnalyzerMinbias.cc and Calibration/HcalCalibAlgos/plugins/SimAnalyzerMinbias.cc (with corresponding changes in config)
move Calibration/HcalCalibAlgos/plugins/HcalIsoTrkAnalyzer.cc to be one module with SharedResources API;
possibility to consume the raw energy of a RecHit in HB/HE via a boolean flag in the functions defined in Calibration/IsolatedParticles/interface/FindDistCone.h, Calibration/IsolatedParticles/interface/eCone.h, and Calibration/IsolatedParticles/interface/FindDistCone.h, and Calibration/IsolatedParticles/interface/eHCALMatrix.h, and corresponding usage in Calibration/HcalCalibAlgos/plugins/HcalHBHEMuonAnalyzer.cc, Calibration/HcalCalibAlgos/plugins/HcalIsoTrkAnalyzer.cc
definition of a new function propagateHCALBack in Calibration/IsolatedParticles/interface/CaloPropagateTrack.h in order to assure the same HCAL cell is reached by propagating the track to front and back faces of the HCAL, still not used in any analyser code (claimed to happen in HcalRaddamMuon and HcalHBHEMuonAnalyzer)
study L1T dependence of the IsoTrack calibration in IsolatedParticles/plugins/IsoTrakCalib.cc (HLT study done in in other analysers): in 2015 the L1T seed used, L1_SingleJet68 was heavily prescaled. Reminder: this requires RAWRECO data tier.

To be done:

still a lot of magic numbers in different places (some in the comments here, many more around)
use of not-centrally-maintained functions for track geometric properties
cleanup of "legacy" modules

cmsbuild · 2015-12-10T19:38:02Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-12-11T08:47:57Z

+1

bsunanda:Run2-alca30 Update the codes for IsoTrack and Muon in view of suggestion during calibration activity

Update the codes for IsoTrack and Muon in view of suggestion during c…

ed040e4

…alibration activity

cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 25, 2015

cmsbuild added alca-pending pending-signatures tests-pending orp-pending comparison-pending labels Nov 25, 2015

cmsbuild added tests-started and removed tests-pending labels Nov 25, 2015

cmsbuild added tests-approved and removed tests-started labels Nov 25, 2015

cmsbuild added comparison-available and removed comparison-pending labels Nov 26, 2015

AnalyzerMinbias should be in plugins

ebdb93a

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Nov 30, 2015

cmsbuild added tests-started and removed tests-pending labels Nov 30, 2015

cmsbuild added tests-pending comparison-pending labels Dec 7, 2015

cmsbuild added tests-started and removed tests-pending labels Dec 7, 2015

cmsbuild added tests-approved and removed tests-started labels Dec 7, 2015

cmsbuild added comparison-available and removed comparison-pending labels Dec 7, 2015

diguida reviewed Dec 10, 2015
View reviewed changes

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Dec 10, 2015

cmsbuild added orp-approved and removed orp-pending labels Dec 11, 2015

cmsbuild added a commit that referenced this pull request Dec 11, 2015

Merge pull request #12573 from bsunanda/Run2-alca30

460922a

bsunanda:Run2-alca30 Update the codes for IsoTrack and Muon in view of suggestion during calibration activity

cmsbuild merged commit 460922a into cms-sw:CMSSW_8_0_X Dec 11, 2015

diguida mentioned this pull request Dec 20, 2015

bsunanda:Run2-alca31 Small improvement to the calibration algorithm with muon and isotracks #12831

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bsunanda:Run2-alca30 Update the codes for IsoTrack and Muon in view of suggestion during calibration activity #12573

bsunanda:Run2-alca30 Update the codes for IsoTrack and Muon in view of suggestion during calibration activity #12573

bsunanda commented Nov 25, 2015

bsunanda commented Nov 25, 2015

cmsbuild commented Nov 25, 2015

cmsbuild commented Nov 25, 2015

bsunanda commented Nov 25, 2015

cmsbuild commented Nov 25, 2015

cmsbuild commented Nov 26, 2015

mmusich commented Nov 26, 2015

bsunanda commented Nov 30, 2015

cmsbuild commented Nov 30, 2015

cmsbuild commented Nov 30, 2015

cmsbuild commented Dec 7, 2015

bsunanda commented Dec 7, 2015

cmsbuild commented Dec 7, 2015

cmsbuild commented Dec 7, 2015

cmsbuild commented Dec 7, 2015

diguida Dec 10, 2015

diguida commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

davidlange6 commented Dec 11, 2015

bsunanda:Run2-alca30 Update the codes for IsoTrack and Muon in view of suggestion during calibration activity #12573

bsunanda:Run2-alca30 Update the codes for IsoTrack and Muon in view of suggestion during calibration activity #12573

Conversation

bsunanda commented Nov 25, 2015

bsunanda commented Nov 25, 2015

cmsbuild commented Nov 25, 2015

cmsbuild commented Nov 25, 2015

bsunanda commented Nov 25, 2015

cmsbuild commented Nov 25, 2015

cmsbuild commented Nov 26, 2015

mmusich commented Nov 26, 2015

bsunanda commented Nov 30, 2015

cmsbuild commented Nov 30, 2015

cmsbuild commented Nov 30, 2015

cmsbuild commented Dec 7, 2015

bsunanda commented Dec 7, 2015

cmsbuild commented Dec 7, 2015

cmsbuild commented Dec 7, 2015

cmsbuild commented Dec 7, 2015

diguida Dec 10, 2015

Choose a reason for hiding this comment

diguida commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

davidlange6 commented Dec 11, 2015