-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to HGC-BH Digitization + Code cleanup. #12584
Conversation
This PR will fail unit tests until #12438 is merged. |
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_0_X. It involves the following packages: SimCalorimetry/HGCalSimProducers @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
Recalling that in 800pre1 (where I did the tests) the HEF and HEB are switched, here is the comparison for pT = 100 GeV pions in the HGCal. As can be seen clearly, previously we were getting some buggy distribution that doesn't even corresponded to noise, where now a physical distribution is generated. |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 8b49b09 ---> test runtestSimCalorimetryHGCalSimProducers had ERRORS you can see the results of the tests here: |
-1 Tested at: 8b49b09 ---> test runtestSimCalorimetryHGCalSimProducers had ERRORS you can see the results of the tests here: |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 8b49b09 ---> test runtestSimCalorimetryHGCalSimProducers had ERRORS you can see the results of the tests here: |
-1 Tested at: 6cbbef3 ---> test runtestSimCalorimetryHGCalSimProducers had ERRORS you can see the results of the tests here: |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Fixes to HGC-BH Digitization + Code cleanup.
This PR fixes the digitization of the backing hadron calorimeter when using the newer version of the ToT digitization.
The main issue was a double conversion of GeV to keV, which resulted in overflows. Likewise there were some conversions of unsigned values to negative floats which had to be casted appropriately.
There was also a minor refactorization of the code, mainly to use std:array where ever possible, and sticking configuration data inside an "hgc_digi" namespace.
I'll post some plots later that demonstrate the now-functioning digitization.