-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up makeRef and sorting of trajectory #12587
Conversation
@cmsbuild, please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_0_X. It involves the following packages: DataFormats/Common @smuzaffar, @Dr15Jones, @cvuosalo, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Pull request #12587 was updated. @smuzaffar, @Dr15Jones, @cvuosalo, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
-1 Tested at: 2dff611 ---> test TestRunnerPhysicsToolsCondLiteIO had ERRORS you can see the results of the tests here: |
@cmsbuild, please test |
Pull request #12587 was updated. @smuzaffar, @Dr15Jones, @cvuosalo, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
The tests are being triggered in jenkins. |
+1 |
it's not so nice to mix in technical changes which do not produce regressions but need full CMSSW rebuild |
@@ -361,7 +361,7 @@ GroupedCkfTrajectoryBuilder::groupedLimitedCandidates (const TrajectorySeed& see | |||
if ((int)newCand.size() > theMaxCand) { | |||
//ShowCand()(newCand); | |||
|
|||
sort( newCand.begin(), newCand.end(), GroupedTrajCandLess(theLostHitPenalty,theFoundHitBonus)); | |||
std::nth_element( newCand.begin(), newCand.begin()+theMaxCand, newCand.end(), GroupedTrajCandLess(theLostHitPenalty,theFoundHitBonus)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the remaining code using the "newCand" care about the order of the trajectories (the part that's left from begin to +maxCand)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it is a side effect
... just 174 packages, peanuts. |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Thanks for confirming. |
+1 |
Speed up makeRef and sorting of trajectory
Two independent optimizations
makeRef avoiding multiple deferencing of Handle
use nth_element to "sort" Trajectory (it may produce regression)