Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a small bug in tracking validation scripts #12706

Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 8, 2015

This PR fixes a small bug that slipped in in #12666 (the generated "Out of the box" page gets screwed up).

Tested in CMSSW_8_0_X_2015-12-07-1100. Should have no effect on standard workflows.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2015

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

Validation/RecoTrack

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@VinInn
Copy link
Contributor

VinInn commented Dec 8, 2015

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10194/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2015

@deguio
Copy link
Contributor

deguio commented Dec 8, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Dec 9, 2015
Fix a small bug in tracking validation scripts
@davidlange6 davidlange6 merged commit 1d22413 into cms-sw:CMSSW_8_0_X Dec 9, 2015
@makortel makortel deleted the fixTrackingValidationScript branch October 20, 2016 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants