Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix phase1 naming for bpix sectors #12719

Merged
merged 1 commit into from
Dec 11, 2015

Conversation

dkotlins
Copy link
Contributor

@dkotlins dkotlins commented Dec 9, 2015

Fix the ladder to sector translation for phase 1bpix.
Harmless to phase0.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

A new Pull Request was created by @dkotlins for CMSSW_8_0_X.

It involves the following packages:

DataFormats/SiPixelDetId

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @VinInn this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@civanch
Copy link
Contributor

civanch commented Dec 9, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10219/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Dec 10, 2015

+1
there are increased number of problematic comparisons which likely due to the IB and not this PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 11, 2015
fix phase1 naming for bpix sectors
@cmsbuild cmsbuild merged commit f2b93e2 into cms-sw:CMSSW_8_0_X Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants