Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Worker handling in UnscheduledCallProducer #12731

Conversation

Dr15Jones
Copy link
Contributor

As a first step to begin migrating to multiple threads per event we
need to change how unscheduled is handled. Start by consolidating
handling of unscheduled Workers into parts that change and parts that
remain stable to avoid false sharing across cache lines.

As a first step to begin migrating to multiple threads per event we
need to change how unscheduled is handled. Start by consolidating
handling of unscheduled Workers into parts that change and parts that
remain stable to avoid false sharing across cache lines.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10220/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Dec 10, 2015
…lProducer

Consolidate Worker handling in UnscheduledCallProducer
@davidlange6 davidlange6 merged commit 48bb44c into cms-sw:CMSSW_8_0_X Dec 10, 2015
@Dr15Jones Dr15Jones deleted the beginMigratingUnscheduledCallProducer branch January 6, 2016 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants