-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WithTrackAngle TTRHBuilder for bunch of producers in Phase1 #12736
Conversation
Use the one without pixel templates for these too.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X. It involves the following packages: SLHCUpgradeSimulations/Configuration @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Use WithTrackAngle TTRHBuilder for bunch of producers in Phase1
The phase1 workflow prints
many times. The fix is to use
WithTrackAngle
TTRHBuilder for these modules too for now.Tested in 8_0_0_pre2, no changes expected in run2, but there can be minuscule changes in phase1.
@rovere @VinInn @boudoul