Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of seeds and built tracks to trackingOnly validation #12747

Merged
merged 5 commits into from
Dec 19, 2015

Conversation

makortel
Copy link
Contributor

This PR adds MultiTrackValidator instances for seeds and built tracks to the trackingOnly validation. Following @lveldere's comment #12542 (comment), the "slim" and validation sequences are removed (and I believe the trackingOnly validation sequences should fulfill the use-case of TrajectorySeedValidation_cff.py, so I removed that too).

In addition, the LogWarning in TrackFromSeedProducer is downgraded to LogInfo, and monitoring of the number of seeds for which the fit fails is added to MTV. Also the dqmFastTimerServiceClient is added to the trackingOnly DQM harvesting to have the FastTimerService histograms.

Tested in CMSSW_8_0_X_2015-12-09-1600, no changes expected in standard workflows.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

Configuration/StandardSequences
DQMOffline/Configuration
Validation/RecoTrack

@cmsbuild, @franzoni, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @istaslis, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @wmtford, @cerati, @threus, @dgulhan, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@slava77
Copy link
Contributor

slava77 commented Dec 10, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10237/console

@lveldere
Copy link
Contributor

thanks matti!

@cmsbuild
Copy link
Contributor

-1
Tested at: 2665507
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

134.911 step3

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12747/10237/summary.html

@makortel
Copy link
Contributor Author

Could somebody restart the tests? Thanks.

@slava77
Copy link
Contributor

slava77 commented Dec 14, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10286/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@makortel
Copy link
Contributor Author

DQM & operations, could you please review and sign? Thanks.

@deguio
Copy link
Contributor

deguio commented Dec 17, 2015

+1

davidlange6 added a commit that referenced this pull request Dec 19, 2015
Add validation of seeds and built tracks to trackingOnly validation
@davidlange6 davidlange6 merged commit a379b35 into cms-sw:CMSSW_8_0_X Dec 19, 2015
@makortel makortel deleted the seedBuildingValidation branch October 20, 2016 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants