-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation of seeds and built tracks to trackingOnly validation #12747
Add validation of seeds and built tracks to trackingOnly validation #12747
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X. It involves the following packages: Configuration/StandardSequences @cmsbuild, @franzoni, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
thanks matti! |
-1 runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log 8.0 step3 runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log 134.911 step3 runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log 140.53 step2 runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log 25.0 step3 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log 1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log 1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log you can see the results of the tests here: |
Could somebody restart the tests? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
DQM & operations, could you please review and sign? Thanks. |
+1 |
Add validation of seeds and built tracks to trackingOnly validation
This PR adds MultiTrackValidator instances for seeds and built tracks to the trackingOnly validation. Following @lveldere's comment #12542 (comment), the "slim" and validation sequences are removed (and I believe the trackingOnly validation sequences should fulfill the use-case of
TrajectorySeedValidation_cff.py
, so I removed that too).In addition, the LogWarning in
TrackFromSeedProducer
is downgraded to LogInfo, and monitoring of the number of seeds for which the fit fails is added to MTV. Also the dqmFastTimerServiceClient is added to the trackingOnly DQM harvesting to have the FastTimerService histograms.Tested in CMSSW_8_0_X_2015-12-09-1600, no changes expected in standard workflows.
@rovere @VinInn