Use unique_ptr when constructing ProductHolders

[Dr15Jones]

Change the interface in Principal from auto_ptr to unique_ptr when constructing ProductHolders.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[Dr15Jones]

please test

[Dr15Jones]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10471/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[Dr15Jones]

thanks!

[cmsbuild]

-1
Tested at: 1a4da2a
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-11-1100/src/DataFormats/Provenance/src/ProductIDToBranchID.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-11-1100/src/DataFormats/Provenance/src/ProductProvenance.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-11-1100/src/DataFormats/Provenance/src/ProductProvenanceRetriever.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-11-1100/src/DataFormats/Provenance/src/ProductRegistry.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-11-1100/src/DataFormats/Provenance/src/Provenance.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-11-1100/src/DataFormats/Provenance/src/ParentageRegistry.cc:36:18: error: no member named 'emplace' in 'tbb::interface5::concurrent_unordered_mapedm::Hash<5, edm::Parentage, edm::ParentageRegistry::key_hash, std::equal_toedm::Hash<5 >, tbb::tbb_allocator, edm::Parentage> > >'
    return m_map.emplace(v.id(),std::move(v)).second;
           ~~~~~ ^
1 error generated.
gmake: **\* [tmp/slc6_amd64_gcc493/src/DataFormats/Provenance/src/DataFormatsProvenance/ParentageRegistry.o] Error 1
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-11-1100/src/DataFormats/Provenance/src/RunAux.cc 


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12920/10471/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a9ff245
49d3978
48adf22
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12920/10471/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12920/10471/git-merge-result

[Dr15Jones]

llvm is unhappy? I don't think it came from this pull since that file doesn't read the header I changed.

[davidlt]

Known issue. Needs to be fixed at TBB level to properly detect Clang in this case. You don't get C++11 emplace with Clang because Clang reports GCC 4.2.1 compatibility.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12920/10471/summary.html