Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ModuleDescription access to stream modules #1295

Merged
merged 1 commit into from Nov 7, 2013
Merged

Added ModuleDescription access to stream modules #1295

merged 1 commit into from Nov 7, 2013

Conversation

Dr15Jones
Copy link
Contributor

When ModuleDescription access was added to the other module types, the stream types were accidentally left out. This makes them uniform with all the other types.

@Dr15Jones
Added ModuleDescription access to stream modules
3e6d0aa 
When ModuleDescription access was added to the other module types, the stream types were accidentally left out. This makes them uniform with all the other types.
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2013

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Added ModuleDescription access to stream modules

It involves the following packages:

FWCore/Framework

@Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor Author

+1
As long as Jenkin's is happy

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

fwyzard added a commit to fwyzard/cmssw that referenced this pull request Nov 3, 2013
@fwyzard
Merge pull request cms-sw#1295 from Dr15Jones/addModuleDescriptionAcc…
546b027 
…essToStreamModules
@fwyzard fwyzard mentioned this pull request Nov 3, 2013
Merged
@Dr15Jones
Copy link
Contributor Author

@ktf @nclopezo David, Giulio, it looks like this pull request was never tested.

@nclopezo
Copy link
Contributor

nclopezo commented Nov 7, 2013

@Dr15Jones

Hi Chris,

Sorry, I missed this one, I just started the tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2013

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1229/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 7, 2013
@ktf
Merge pull request #1295 from Dr15Jones/addModuleDescriptionAccessToS…
7adb8fe 
…treamModules

Multithreaded framework -- Added ModuleDescription access to stream modules
@ktf ktf merged commit 7adb8fe into cms-sw:CMSSW_7_0_X Nov 7, 2013
@Dr15Jones Dr15Jones deleted the addModuleDescriptionAccessToStreamModules branch November 14, 2013 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @nclopezo @ktf