Updated N-subjettiness computation in BoostedDoubleSecondaryVertex tagger

[ferencek]

Backport of a single commit from #12984

This PR updates the way the N-subjettiness is computed in the BoostedDoubleSecondaryVertex tagger. This change is necessary in order to collect all the jet constituents of slimmedJetsAK8 stored in MiniAOD where subjets and the remaining jet constituents are added as daughters. This is a follow-up to #12890

The code changes affect the pfBoostedDoubleSecondaryVertexAK8BJetTags discriminator embedded in slimmedJetsAK8 in MiniAOD but should leave its numerical values unchanged.

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_7_6_X.

It involves the following packages:

RecoBTag/SecondaryVertex

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[slava77]

@ferencek
#12890 is not merged yet.
Is this PR logically independent of #12890? Meaning, would either of them work separately and still make sense?
If not, #12890 should be either updated or superseded.

[ferencek]

@slava77, the two PRs are essentially independent. This PR is only needed if one wants to remake the pfBoostedDoubleSecondaryVertexAK8BJetTags discriminator from slimmedJetsAK8. Logically, it belongs to #12984 and is the only piece of it that can be backported without affecting the standard reco and MiniAOD production in 76X.

So I think it should be fine to have it as a separate PR especially given the fact that #12890 was already tested and signed.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10585/console

[cmsbuild]

+1
Tested at: 2092595
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12988/10585/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12988/10585/summary.html

[slava77]

+1

for #12988 2092595

• code changes are in line with the description; only tagging using miniAOD as input is affected
• jenkins tests pass and comparisons with baseline show no differences (the tagger values in miniAOD are not monitored)
  • inspection of the local copy of miniAOD outputs from jenkins for 134.911 and 25202.0 shows there are no differences in slimmedJetsAK8 tag values

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1