Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implimenting HLTConfigData::globalTag() function #13145

Merged
merged 1 commit into from Feb 9, 2016

Conversation

Sam-Harper
Copy link
Contributor

HLTConfigData::globalTag() was not actually implemented. This is a fairly minor issue but also straightforward to fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

A new Pull Request was created by @Sam-Harper for CMSSW_7_6_X.

It involves the following packages:

HLTrigger/HLTcore

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

Ooops

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10884/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

@Martin-Grunewald
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

@Sam-Harper
Thanks, Sam!

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@Sam-Harper
Copy link
Contributor Author

@Martin-Grunewald, np, easily missed and easy fix. Want me to port it to CMSSW_8?

@Martin-Grunewald
Copy link
Contributor

Already done - #13146 - but thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 9, 2016
Implimenting HLTConfigData::globalTag() function
@cmsbuild cmsbuild merged commit f53f9c2 into cms-sw:CMSSW_7_6_X Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants