Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to 'getByToken', TQAF. #1318

Merged
merged 1 commit into from
Nov 6, 2013
Merged

Migration to 'getByToken', TQAF. #1318

merged 1 commit into from
Nov 6, 2013

Conversation

vadler
Copy link

@vadler vadler commented Nov 4, 2013

Migration of TQAF to 'consumes'/'getByToken'-API.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2013

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_7_0_X.

Migration to 'getByToken', TQAF.

It involves the following packages:

TopQuarkAnalysis/TopObjectResolutions
TopQuarkAnalysis/Examples
TopQuarkAnalysis/TopEventProducers
TopQuarkAnalysis/TopEventSelection
TopQuarkAnalysis/TopKinFitter
TopQuarkAnalysis/TopJetCombination
TopQuarkAnalysis/TopHitFit

@vadler, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@vadler
Copy link
Author

vadler commented Nov 4, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2013

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1195/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 6, 2013
@ktf
Merge pull request #1318 from vadler/70X-consumesMigration-TQAF
9a6bdcc 
Consumes migration -- Migration to 'getByToken', TQAF.
@ktf ktf merged commit 9a6bdcc into cms-sw:CMSSW_7_0_X Nov 6, 2013
@vadler vadler deleted the 70X-consumesMigration-TQAF branch November 6, 2013 15:00
@vadler vadler restored the 70X-consumesMigration-TQAF branch November 6, 2013 15:00
@vadler vadler deleted the 70X-consumesMigration-TQAF branch November 8, 2013 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre9
Development

Successfully merging this pull request may close these issues.
3 participants
@vadler @cmsbuild @ktf