Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MillePede workflow using weights for the input data (Backport of #13321). #13323

Conversation

ghellwig
Copy link

  • strip off a possible weight directive before checking if file exists
  • added more logging to detect possible misconfiguration

Backport of #13321

 - strip off a possible weight directive before checking if file exists
 - added more logging to detect possible misconfiguration
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_7_5_X.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Feb 17, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11275/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Feb 17, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6 davidlange6 merged commit 2fd34a7 into cms-sw:CMSSW_7_5_X Mar 30, 2016
@ghellwig ghellwig deleted the fix_MillePede_use-case_with_weights_75X branch June 17, 2016 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants