Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hlt tau ref producer update #13455

Merged
merged 2 commits into from Mar 4, 2016

Conversation

slehti
Copy link
Contributor

@slehti slehti commented Feb 24, 2016

This is the same PR as #13426, but now for cmssw80x

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slehti for CMSSW_8_0_X.

It involves the following packages:

DQMOffline/Trigger
HLTriggerOffline/Tau

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mbluj
Copy link
Contributor

mbluj commented Feb 25, 2016

Hi, just to complete info on this PR. It is meant to fix DQM issue which was a side effect of #13272 which removes obsolete tau discriminants. The effect was understood to be result of a bad logic of tau trigger DQM module which accepted all probes in case of missing discriminant used to select the probes. Code was updated to reject all probes in case of call for a missing discrimiant which should be easy to detect, and a list of discriminants was updated to supported ones. This should revert to behavior very close to the one known before merging #13272.

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

please test

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11630/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

@mbluj
Copy link
Contributor

mbluj commented Mar 3, 2016

Dear All,
is there anything preventing to merge it to 80X? This is a fix of a dqm issue being a side effect of already merged #13272.
For reference, a sibling PR for 81X (#13426) is already merged.

davidlange6 added a commit that referenced this pull request Mar 4, 2016
@davidlange6 davidlange6 merged commit 17700b7 into cms-sw:CMSSW_8_0_X Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants