-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hlt tau ref producer update #13455
Hlt tau ref producer update #13455
Conversation
A new Pull Request was created by @slehti for CMSSW_8_0_X. It involves the following packages: DQMOffline/Trigger @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
Hi, just to complete info on this PR. It is meant to fix DQM issue which was a side effect of #13272 which removes obsolete tau discriminants. The effect was understood to be result of a bad logic of tau trigger DQM module which accepted all probes in case of missing discriminant used to select the probes. Code was updated to reject all probes in case of call for a missing discrimiant which should be easy to detect, and a list of discriminants was updated to supported ones. This should revert to behavior very close to the one known before merging #13272. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Hlt tau ref producer update
This is the same PR as #13426, but now for cmssw80x