Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HLTJetL1TMatchProducer as simplified stage2L1-version with corres… #13468

Conversation

kirschen
Copy link
Contributor

…ponding filldescriptions and dropped Tau/Central/Forward inputs

…ponding filldescriptions and dropped Tau/Central/Forward inputs
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kirschen for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

We'd need a PR for 80X as well!

@Martin-Grunewald
Copy link
Contributor

please test

@kirschen
Copy link
Contributor Author

backport: #13469

@cmsbuild
Copy link
Contributor

-1
Tested at: 380cdc6
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13468/11541/summary.html


bool isMatched=false;

for (unsigned int jetc=0;jetc<l1Jets->size();++jetc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to select the l1t objects on BX=0 (or make BX configurable and code that part), see the example code in cms-l1t-offline#156

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11565/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #13468 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please check and sign again.

@kirschen
Copy link
Contributor Author

Selected the l1t objects on BX=0 as suggested by Martin. Here and in #13469

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11595/console

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 27, 2016
…Producer_ForStage2L1

add HLTJetL1TMatchProducer as simplified stage2L1-version with corres…
@cmsbuild cmsbuild merged commit 3cbbe83 into cms-sw:CMSSW_8_1_X Feb 27, 2016
cmsbuild added a commit that referenced this pull request Mar 1, 2016
…Producer_ForStage2L1

add HLTJetL1TMatchProducer as simplified stage2L1-version - backport of #13468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants