Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tracks from V0, and fixing bug in photon conversion producer #13483

Merged
merged 4 commits into from
Mar 6, 2016

Conversation

alberto-sanchez
Copy link
Member

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for CMSSW_8_1_X.

It involves the following packages:

HeavyFlavorAnalysis/Onia2MuMu
HeavyFlavorAnalysis/Skimming

@cmsbuild, @vadler, @davidlange6, @monttj can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11668/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

Pull request #13483 was updated. @cmsbuild, @vadler, @davidlange6, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

@davidlange6
Copy link
Contributor

please test
@smuzaffar @iahmad-khan - seems we have a bug in the labels here - the PR was updating while the comparisons were in progress. If that happens we should try to keep "comparison-pending" instead of "comparison-available"

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11682/console

@smuzaffar
Copy link
Contributor

@davidlange6 , this is fixed in cms-bot.
comparison(-available|-notrun) label should only be add if tests were ran previously and tests status is reset on PR update.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

davidlange6 added a commit that referenced this pull request Mar 6, 2016
Adding tracks from V0, and fixing bug in photon conversion producer
@davidlange6 davidlange6 merged commit 7e238c0 into cms-sw:CMSSW_8_1_X Mar 6, 2016
@alberto-sanchez alberto-sanchez deleted the onia2mumu-81x branch May 19, 2016 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants