Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::abs for enum (tauImpactParameter::PDGInfo::PDGMCNumbering) #13616

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Mar 7, 2016

The following errors are reported by GCC (6.0.0, r233941):

RecoTauTag/ImpactParameter/src/TauA1NuConstrainedFitter.cc:179:98: error: call of overloaded 'fabs(tauImpactParameter::PDGInfo::PDGMCNumbering)' is ambiguous

Include missing header, add std:: where needed and change
std::fabs to std::abs for int type (enum, PDGInfo::PDGMCNumbering).

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The following errors are reported by GCC (6.0.0, r233941):

    RecoTauTag/ImpactParameter/src/TauA1NuConstrainedFitter.cc:179:98: error: call of overloaded 'fabs(tauImpactParameter::PDGInfo::PDGMCNumbering)' is ambiguous

Include missing <cmath> header, add std:: where needed and change
std::fabs to std::abs for int type (enum, PDGInfo::PDGMCNumbering).

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

A new Pull Request was created by @davidlt for CMSSW_8_1_X.

It involves the following packages:

RecoTauTag/ImpactParameter

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

davidlange6 added a commit that referenced this pull request Mar 7, 2016
…ter-abs

Use std::abs for enum (tauImpactParameter::PDGInfo::PDGMCNumbering)
@davidlange6 davidlange6 merged commit 8970a1b into cms-sw:CMSSW_8_1_X Mar 7, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants