-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the missing linking between plot and refplot (8_1_X) #13679
Fixed the missing linking between plot and refplot (8_1_X) #13679
Conversation
When a reference plot is loaded, it searches for the corresponding non-reference plot and updates the link from the non-reference plot to the reference plot. This was implemented. When a non-reference plot is loaded, it searches for the corresponding reference plot, but it forgot to do the actual linking. (It was just setting flags, but nothing else.) So this is what we implemented now.
A new Pull Request was created by @vanbesien (Broen van Besien) for CMSSW_8_1_X. It involves the following packages: DQMServices/Core @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Fixed the missing linking between plot and refplot (8_1_X)
When a reference plot is loaded, it searches for the corresponding
non-reference plot and updates the link from the non-reference plot to
the reference plot. This was already implemented.
When a non-reference plot is loaded, it searches for the corresponding
reference plot, but it forgot to do the actual linking. (It was just
setting flags, but nothing else.) So this is what we implemented now.
This fixes the reference plots during live running in the online.