Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the missing linking between plot and refplot (8_1_X) #13679

Merged

Conversation

vanbesien
Copy link
Contributor

When a reference plot is loaded, it searches for the corresponding
non-reference plot and updates the link from the non-reference plot to
the reference plot. This was already implemented.
When a non-reference plot is loaded, it searches for the corresponding
reference plot, but it forgot to do the actual linking. (It was just
setting flags, but nothing else.) So this is what we implemented now.

This fixes the reference plots during live running in the online.

When a reference plot is loaded, it searches for the corresponding
non-reference plot and updates the link from the non-reference plot to
the reference plot. This was implemented.
When a non-reference plot is loaded, it searches for the corresponding
reference plot, but it forgot to do the actual linking. (It was just
setting flags, but nothing else.) So this is what we implemented now.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vanbesien (Broen van Besien) for CMSSW_8_1_X.

It involves the following packages:

DQMServices/Core

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@vanbesien
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11823/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@vanbesien
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Mar 12, 2016
Fixed the missing linking between plot and refplot (8_1_X)
@davidlange6 davidlange6 merged commit 2b2bd23 into cms-sw:CMSSW_8_1_X Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants