Rekovic hlt 802 seed unpacked gt

[rekovic]

// Two GT objects are obtained from the Event: (1) the unpacked GT and (2) the emulated GT.
// Return value of the filter is the score of seeding logical expression, evaluated using (1).
// Seeding is performed (per l1_algo) if ACCEPT both in (1) and (2). Seed objects are identified 
// and only available from ObjectMaps created in (2).

[cmsbuild]

A new Pull Request was created by @rekovic for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/HLTfilters

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11855/console

[cmsbuild]

+1
Tested at: 7fc5ca4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13702/11855/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13702/11855/summary.html

[fwyzard]

@rekovic , can you check if using this change on top of CMSSW_8_0_1 (which has the uGT unpacker bug) the HLTL1TSeed module fails for all bits > 127 ?

[fwyzard]

@rekovic, since it looks like they are no longer used, do you think it would make sense to remove

• the seedsAll method
• the m_utml1GtMenu and m_l1GtMenuCacheID data members
  ?

[rekovic]

@fwyzard

can you check if using this change on top of CMSSW_8_0_1 (which has the uGT unpacker bug) the HLTL1TSeed module fails for all bits > 127 ?

This, effectively the same, check was done in CMSSW_8_0_2 by re-introducing the bug (to extreme)

maxPhysicsTriggers = 512 --> 1

in which case HLTL1TSeed modules that seed with l1algos bits > 1 all FAIL, which originally PASS.

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[rekovic]

@fwyzard

since it looks like they are no longer used, do you think it would make sense to remove the seedsAll method the m_utml1GtMenu and m_l1GtMenuCacheID data members ?

I would still keep them. In the new version, the method seedsAll would be useable and configurable. Storing the information about the menu in m_utml1GtMenu and m_l1GtMenuCacheID is intended to be in use when re-running an HLT menu.

[fwyzard]

In the new version, the method seedsAll would be usable and configurable.

But what would be the use case for it ?

Storing the information about the menu in m_utml1GtMenu and m_l1GtMenuCacheID is intended to be in use when re-running an HLT menu.

Ehm, what for, exactly ?
Do you foresee a third configurable "mode", which would run without any object map ?

[cmsbuild]

Pull request #13702 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please check and sign again.

[rekovic]

please test

[cmsbuild]

+1
Tested at: 8931109
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13702/11860/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13702/11860/summary.html

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11870/console

[cmsbuild]

+1
Tested at: e7d038f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13702/11870/summary.html

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13702/11870/summary.html

[davidlange6]

+1