Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add decay file for BPH #13783

Merged
merged 1 commit into from Mar 30, 2016
Merged

add decay file for BPH #13783

merged 1 commit into from Mar 30, 2016

Conversation

heppye
Copy link
Contributor

@heppye heppye commented Mar 20, 2016

add decay file for BPH

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @heppye (Ye Chen) for CMSSW_5_3_X.

It involves the following packages:

GeneratorInterface/ExternalDecays

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@inugent, @agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@covarell
Copy link
Contributor

What is the need for the new .pdl file?

@heppye
Copy link
Contributor Author

heppye commented Mar 21, 2016

this pdl is for analysis of new resonance search via Lambdab decay. The requests are BPH-Summer12-00201/00202/00203. Since the lifetime of lambdab needs to be udpated, changing 'Particle' in evtgen decay file does not work. I have checked the evtgen code and also confirmed with current evtgen interface developer that it might be the way to make the property change. Please let me know if you have any further suggestions. Thanks, Ye

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11984/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@covarell
Copy link
Contributor

I hope you realize that when you add these decay files only to 53X, they will all be lost in the master development release (which currently is 81X) so you cannot use them anymore at 13 TeV... This happened already a few times, so I am wondering...

@heppye
Copy link
Contributor Author

heppye commented Mar 22, 2016

thanks for the reminder. This PR is prepared in a kind of rush especially for the exceptional BPH RunI HPA. Ok, I will make another PR to 81X later for further usage. Thanks, Ye.

@covarell
Copy link
Contributor

Ok! Please in general have a look that the repositories of 53X, 71X and 81X contain the same files. If not, you can make global PRs for back- (forward-)porting all the missing ones (not one by one, please)

@heppye
Copy link
Contributor Author

heppye commented Mar 22, 2016

ok.

@inugent
Copy link
Contributor

inugent commented Mar 22, 2016

Please remove me from this thread. I am no longer on cms.

On Mar 22, 2016, at 8:07 AM, Roberto Covarelli notifications@github.com wrote:

I hope you realize that when you add these decay files only to 53X, they will all be lost in the master development release (which currently is 81X) so you cannot use them anymore at 13 TeV... This happened already a few times, so I am wondering...


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@davidlange6
Copy link
Contributor

+1
@smuzaffar - could you remove @inugent from the list of people that opted-in to getting notifications from cmsbot? Thanks!

@cmsbuild cmsbuild merged commit d2460a3 into cms-sw:CMSSW_5_3_X Mar 30, 2016
@smuzaffar
Copy link
Contributor

@davidlange6 , done cms-sw/cms-bot@f99c42c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants