bsunanda:Run2-hcx76 Remove wrong warnings #13915
Conversation
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: CalibCalorimetry/CaloTPG @cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
+1 |
|
+1 |
|
@bsunanda I temporarily remove my +1, I would like to understand if this prevents by any means of spotting inconsistent geometry and calibrations (as we recently experienced during preparation of 2016 data-taking) |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
| @@ -13,9 +13,9 @@ HcalCondObjectContainerBase::HcalCondObjectContainerBase(const HcalTopology* top | |||
| } | |||
|
|
|||
| void HcalCondObjectContainerBase::setTopo(const HcalTopology* topo) { | |||
| if (topo && !topo->denseIdConsistent(packedIndexVersion_)) { | |||
| if ((topo) && (packedIndexVersion_ != 0) && | |||
There was a problem hiding this comment.
@bsunanda which use case (packedIndexVersion_ != 0) is supposed to take care of?
There was a problem hiding this comment.
The default constructor initializes packedIndexVersion_ = 0
It does not know at that stage what the packed index version is. Ideally the default constructor should know the packed index version at the time of construction. Unfortunately the packed index version is not saved in the data base (except the geometry in DB). We may at some point in time utilize that. It will come later on. At the moment the code is unprotected and this warning is totally misleading
From: Marco Musich [notifications@github.com]
Sent: 05 April 2016 14:37
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cms-sw/cmssw] bsunanda:Run2-hcx76 Remove wrong warnings (#13915)
In CondFormats/HcalObjects/src/HcalCondObjectContainerBase.cchttps://github.com//pull/13915#discussion_r58529923:
@@ -13,9 +13,9 @@ HcalCondObjectContainerBase::HcalCondObjectContainerBase(const HcalTopology* top
}void HcalCondObjectContainerBase::setTopo(const HcalTopology* topo) {
- if (topo && !topo->denseIdConsistent(packedIndexVersion_)) {
- if ((topo) && (packedIndexVersion_ != 0) &&
@bsunandahttps://github.com/bsunanda which use case (packedIndexVersion_ != 0) is supposed to take care of?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com//pull/13915/files/8b8909957f8e7e2d99992087483b106ff7e2b6b8#r58529923
cmsbuild
added
alca-pending
pending-signatures
and removed
alca-approved
fully-signed
labels
|
@mmusich Could you approve this PR? |
|
@mmusich |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Wrong warnings in HcalCondObjectContainer and CaloTPGTranscoderULUT are removed