-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New KeyList; Solved name clash in OSX for time::MAX/MIN #1394
Conversation
A new Pull Request was created by @ggovi for CMSSW_7_0_X. New KeyList; Solved name clash in OSX for time::MAX/MIN It involves the following packages: CondCore/ORA @ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks. |
@@ -19,7 +19,8 @@ | |||
class CondGetter { | |||
public: | |||
virtual ~CondGetter(){} | |||
virtual IOVProxy get(std::string name) const=0; | |||
//virtual IOVProxy get(std::string name) const=0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove instead of comment.
Pull request #1394 was updated. @ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
DB improvements -- New KeyList; Solved name clash in OSX for time::MAX/MIN
Introduced new KeyList implementation with the associated PayloadProxy. Fixes for ORAWrapper.
Renamed time::MAX and time::MIN to avoid name clash in OSX