remove static qualifier #1433
remove static qualifier #1433
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X. remove static qualifier It involves the following packages: RecoTracker/MeasurementDet @nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks. |
| std::vector<uint32_t> rawInactiveDetIds; | ||
| if (!theInactivePixelDetectorLabels.empty()) { | ||
| edm::Handle<DetIdCollection> detIds; | ||
| bool iFailedAlready =false; |
There was a problem hiding this comment.
Every time this routine is called, it may print the LogError. That wasn't the intent of the code. I'd instead make this a
static std::atomic<bool> iFailedAlready{ false };
| @@ -67,7 +66,7 @@ | |||
| if (event.getByLabel(*itt, detIds)){ | |||
| rawInactiveDetIds.insert(rawInactiveDetIds.end(), detIds->begin(), detIds->end()); | |||
| }else{ | |||
| static bool iFailedAlready=false; | |||
| static std::atomic<bool> iFailedAlread{false}; | |||
| if (!iFailedAlready){ | |||
There was a problem hiding this comment.
Here you want to do
bool expected = false;
if(iFailedAlready.compare_exchange_strong(expected,true,std::memory_order_acq_rel) ) {
and then get rid of the iFailedAlready=true. That code change will guarantee that the printout will happen once and only once.
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Multithreading fixes -- Make static atomic in RecoTracker/MeasurementDet
No description provided.